Skip to content

[k2] add curl, part 3#1462

Merged
PetrShumilov merged 15 commits intomasterfrom
pshumilov/k2_curl_part3
Dec 8, 2025
Merged

[k2] add curl, part 3#1462
PetrShumilov merged 15 commits intomasterfrom
pshumilov/k2_curl_part3

Conversation

@PetrShumilov
Copy link
Copy Markdown
Contributor

@PetrShumilov PetrShumilov commented Nov 25, 2025 •
edited
Loading

This is the continue of #1426 and #1445

Significant changes:

  • Made the semantics of Easy part is more similar with a reference implementation
  • Reorganized files hierarchy and better naming
  • Supported the whole list of Multi methods:
    • curl_multi_init
    • curl_multi_add_handle
    • curl_multi_remove_handle
    • curl_multi_setopt
    • curl_multi_exec
    • curl_multi_getcontent
    • curl_multi_close
    • curl_multi_errno
    • curl_multi_strerror
    • curl_multi_select
    • curl_multi_info_read

@PetrShumilov PetrShumilov force-pushed the pshumilov/k2_curl_part3 branch from eecdea9 to 1c5f4de Compare November 27, 2025 16:03
@PetrShumilov PetrShumilov self-assigned this Nov 28, 2025
@PetrShumilov PetrShumilov force-pushed the pshumilov/k2_curl_part3 branch 3 times, most recently from ee9f967 to 44f4ec2 Compare November 30, 2025 18:16
@PetrShumilov PetrShumilov added k2 Affects compiler or runtime in K2 mode enhancement New feature or request labels Nov 30, 2025
@PetrShumilov PetrShumilov added this to the next milestone Nov 30, 2025
@PetrShumilov PetrShumilov force-pushed the pshumilov/k2_curl_part3 branch 7 times, most recently from b7e60db to 50c77cd Compare December 2, 2025 14:04
@PetrShumilov PetrShumilov marked this pull request as ready for review December 2, 2025 14:51
@PetrShumilov
Add curl_multi_init
ce585af 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Make easy context resetting more clear
3df38f0 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Refactor contexts management
93826f5 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_add_handle and curl_multi_remove_handle support
0bb0828 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_close support
6c5bbe8 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_setopt support
e5c324b 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_exec support
5a4a528 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_getcontent support
f021269 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_errno and curl_multi_strerror support
8b94d79 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Fix multi_setopt test
3aa9616 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_select support
63f4b88 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl_multi_info_read support
981b663 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Fix code style
a79515c 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add curl multi functional test
a9c3011 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
astrophysik
astrophysik reviewed Dec 5, 2025
View reviewed changes
@PetrShumilov PetrShumilov force-pushed the pshumilov/k2_curl_part3 branch 2 times, most recently from a6237ff to 8cf45ce Compare December 5, 2025 16:20
apolyakov
apolyakov previously approved these changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@apolyakov apolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

astrophysik
astrophysik reviewed Dec 8, 2025
View reviewed changes
@PetrShumilov
Fix code style
6766479 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/k2_curl_part3 branch from 8cf45ce to 6766479 Compare December 8, 2025 13:27
@PetrShumilov PetrShumilov merged commit de18ce5 into master Dec 8, 2025
7 checks passed
@PetrShumilov PetrShumilov deleted the pshumilov/k2_curl_part3 branch December 8, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrophysik astrophysik astrophysik approved these changes

@apolyakov apolyakov apolyakov left review comments

Assignees

@PetrShumilov PetrShumilov

Labels

enhancement New feature or request k2 Affects compiler or runtime in K2 mode

Projects

None yet

Milestone

14.12.2025

Development

Successfully merging this pull request may close these issues.

3 participants

@PetrShumilov @apolyakov @astrophysik